[cfe-commits] r134935 - /cfe/trunk/lib/Basic/Targets.cpp

[Bruno Cardoso Lopes]

On Mon, Jul 11, 2011 at 4:04 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Mon, Jul 11, 2011 at 3:50 PM, Bruno Cardoso Lopes
> <bruno.cardoso at gmail.com> wrote:
>> Author: bruno
>> Date: Mon Jul 11 17:50:13 2011
>> New Revision: 134935
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=134935&view=rev
>> Log:
>> Enable "avx" feature, so it can be seen by llvm
>>
>> Modified:
>>    cfe/trunk/lib/Basic/Targets.cpp
>>
>> Modified: cfe/trunk/lib/Basic/Targets.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=134935&r1=134934&r2=134935&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Basic/Targets.cpp (original)
>> +++ cfe/trunk/lib/Basic/Targets.cpp Mon Jul 11 17:50:13 2011
>> @@ -1220,7 +1220,7 @@
>>     setFeatureEnabled(Features, "mmx", true);
>>     setFeatureEnabled(Features, "sse4", true);
>>     setFeatureEnabled(Features, "aes", true);
>> -//    setFeatureEnabled(Features, "avx", true);
>> +    setFeatureEnabled(Features, "avx", true);
>>   } else if (CPU == "k6" || CPU == "winchip-c6")
>>     setFeatureEnabled(Features, "mmx", true);
>>   else if (CPU == "k6-2" || CPU == "k6-3" || CPU == "athlon" ||
>
> This was intentionally turned off because AVX support is incomplete...
> have you checked to make sure nothing explodes with
> "-march=corei7-avx"?

If it was only turning on 256-bit support that would be OK, but you
are right. There are actually more reasons why this shouldn't be
enabled right now, reverted in r134939 with some explanation.

Thanks Eli,

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc