[cfe-commits] [Patch] Typo correction: don't crash on overloaded functions, pr10283

[Kaelyn Uhrain]

Looks like the indenting on the FIXME you added needs to be fixed so that
the start of both lines of the comment are equal to each other and to the
surrounding code, but otherwise the code changes look fine. One big issue
regarding the unit test though:  the test does not test clang's "-fixit"
code rewrite functionality so should not be under test/FixIt/; test/SemaCXX/
is the appropriate place for this C++ unit test. Naming the file something a
bit more descriptive than just "typo-crash.cpp", such as
"function-overload-typo-crash.cpp", would also be nice.

Cheers,
Kaelyn

On Sat, Jul 9, 2011 at 1:33 PM, Hans Wennborg <hans at chromium.org> wrote:

> Don't crash when typo correction finds an overloaded or template function.
>
> It would be cool if we could do overload resolution to suggest the
> right function here, but this at least fixes the crashing (PR10283).
>
> Ok to commit?
>
> Thanks,
> Hans
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110711/678fa21c/attachment.html>