[cfe-commits] r134587 - in /cfe/trunk: include/clang/Basic/SourceManager.h include/clang/Lex/MacroInfo.h include/clang/Lex/TokenLexer.h lib/ARCMigrate/TransformActions.cpp lib/ARCMigrate/Transforms.cpp lib/Basic/SourceManager.cpp lib/Lex/Lexer.cp

[Argyrios Kyrtzidis]

On Jul 7, 2011, at 6:09 PM, Chandler Carruth wrote:

> On Thu, Jul 7, 2011 at 2:19 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
> Also change the following SM.createInstantiationLoc below this, to handle arguments for the "## __VA_ARGS__" code path
> 
> Done in r134674, please review and let me know if you were thinking of something else.

Thanks, I mainly wanted the arguments that are not involved in the paste to be handled correctly, as they are now.

> 
> I've included a few test cases based on yours, but not your exact one. Let me know if there were particular things in your example you wanted to see tested.
> 
> There is still a suboptimal source location. I've left a fixme in the test case and am looking at how hard fixing that would be.

I also don't like seeing

<scratch space>:2:1: note: instantiated from:
12
^

seeing a full source location from "scratch space" is not very useful, not sure what's the best way to improve it though..
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110708/c41a8a7e/attachment.html>