[cfe-commits] [PATCH] StringRef'ize clang::driver::Option::getName()

Douglas Gregor dgregor at apple.com
Tue Jul 5 09:56:46 PDT 2011


On Jul 1, 2011, at 9:09 AM, Zach Wheeler wrote:

> I forgot to initialize NameLen. :-/
> 
> I stored 'Name' as start+size because I saw that pattern in lib/Basic/DiagnosticID.h, and assumed it was expected. Storing a StringRef makes more sense to me. Here's an updated patch. Clang builds successfully, and hopefully the tests will pass.

Looks good. I've committed this as r134418, thanks!

	- Doug




More information about the cfe-commits mailing list