[cfe-commits] [PATCH] SourceManager re-write for PCH simplification

Sebastian Redl sebastian.redl at getdesigned.at
Thu Jun 30 01:32:38 PDT 2011

On 29.06.2011 20:37, Jonathan Turner wrote:
> This is a resurrected patch originally by Sebastian Redl that rewrites some key elements of the SourceManager.  At a high level, the patch is part of on-going work to help simplify PCH loading.  Special thanks to Doug Gregor for helping me iron out a couple last minute issues.
> This patch has two main features:
> * It removes -chained-pch, and makes chained PCH the only means of PCH reuse
> * It splits FileIDs into two groups.  Those>  0 represent local FileIDs.  Those<  -1 are external, and are taken from loaded PCH files.  This helps to keep us from having to preallocate entries for the PCH in our SLoc "number space".
> It also adds remapping functionality to ReadSourceLocation in ASTReader.h, where the 'module' argument was previously ignored.
Awesome. I planned to resurrect this for quite a while, but just 
couldn't find the time. Nice to see you've taken it up.


More information about the cfe-commits mailing list