[cfe-commits] r133295 - in /cfe/trunk: include/clang/Basic/TokenKinds.def lib/Basic/Targets.cpp lib/Parse/ParseExpr.cpp test/SemaObjC/arc-bridged-cast.m

[Douglas Gregor]

On Jun 17, 2011, at 2:44 PM, Argyrios Kyrtzidis wrote:

> On Jun 17, 2011, at 2:39 PM, Douglas Gregor wrote:
> 
>> 
>> On Jun 17, 2011, at 2:23 PM, John McCall wrote:
>> 
>>> Author: rjmccall
>>> Date: Fri Jun 17 16:23:37 2011
>>> New Revision: 133295
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=133295&view=rev
>>> Log:
>>> As a hopefully temporary workaround for a header mistake, treat
>>> __bridge_retain as a synonym for __bridge_retained.
>> 
>> I really hate to say it, but… we should probably have a hard error + Fix-It for this mis-spelling, but not emit the error if we're in a system header. Otherwise, this bug is likely to leak into user code and we'll *never* get rid of the wrong spelling.
> 
> How about accepting it only in a system header ?

Isn't that what a hard error + Fix-It is? ;)

	- Doug