[cfe-commits] r133232 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.stc/p1.cpp

Douglas Gregor dgregor at apple.com
Thu Jun 16 22:15:05 PDT 2011


On Jun 16, 2011, at 9:04 PM, John McCall wrote:

> 
> On Jun 16, 2011, at 8:41 PM, Douglas Gregor wrote:
> 
>> Author: dgregor
>> Date: Thu Jun 16 22:41:35 2011
>> New Revision: 133232
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=133232&view=rev
>> Log:
>> Downgrade the error complaining about presence of a storage class
>> specifier on an explicit specialization to a warning, since neither
>> EDG nor GCC diagnose this code as ill-formed.
> 
> This seems reasonable, but you should at least still error about an
> *inconsistent* storage class specifier, like adding static to a
> specialization (rather than the reverse) or making one extern and
> the other static or something.


Good point. I've added this checking in r133236.

	- Doug



More information about the cfe-commits mailing list