[cfe-commits] r133157 - in /cfe/trunk: lib/CodeGen/CodeGenModule.cpp test/CodeGen/private-extern-redef.c

jahanian fjahanian at apple.com
Thu Jun 16 13:22:58 PDT 2011


On Jun 16, 2011, at 10:09 AM, John McCall wrote:

> 
> On Jun 16, 2011, at 10:03 AM, jahanian wrote:
> 
>> 
>> 
>> This is not a hack.
>> Idea was not to change the AST. It should reflect user source which is one 'hidden' decl.  followed by another
>> declaration with default visibility. I can certainly move this code to MergeDecl though. Doug, what do you think?
> 
> Whether we change the AST or not, the implementation of getLinkageAndVisibility already does this sort of merging of information from redeclarations.  I agree with Eli;  please revert and fix differently.

Logic moved in r133182.

- fariborz

> 
> John.




More information about the cfe-commits mailing list