[cfe-commits] r133120 - /cfe/trunk/lib/Sema/SemaExpr.cpp

Chandler Carruth chandlerc at gmail.com
Wed Jun 15 18:05:08 PDT 2011


Author: chandlerc
Date: Wed Jun 15 20:05:08 2011
New Revision: 133120

URL: http://llvm.org/viewvc/llvm-project?rev=133120&view=rev
Log:
Cleanup the parameter naming style.

Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=133120&r1=133119&r2=133120&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Wed Jun 15 20:05:08 2011
@@ -6364,13 +6364,13 @@
 /// "int x = a + someBinaryCondition ? 1 : 2".
 static void DiagnoseConditionalPrecedence(Sema &Self,
                                           SourceLocation OpLoc,
-                                          Expr *cond,
-                                          Expr *lhs,
-                                          Expr *rhs) {
+                                          Expr *Condition,
+                                          Expr *LHS,
+                                          Expr *RHS) {
   BinaryOperatorKind CondOpcode;
   Expr *CondRHS;
 
-  if (!IsArithmeticBinaryExpr(cond, &CondOpcode, &CondRHS))
+  if (!IsArithmeticBinaryExpr(Condition, &CondOpcode, &CondRHS))
     return;
   if (!ExprLooksBoolean(CondRHS))
     return;
@@ -6379,21 +6379,21 @@
   // hand side that looks boolean, so warn.
 
   PartialDiagnostic Warn = Self.PDiag(diag::warn_precedence_conditional)
-      << cond->getSourceRange()
+      << Condition->getSourceRange()
       << BinaryOperator::getOpcodeStr(CondOpcode);
 
   PartialDiagnostic FirstNote =
       Self.PDiag(diag::note_precedence_conditional_silence)
       << BinaryOperator::getOpcodeStr(CondOpcode);
 
-  SourceRange FirstParenRange(cond->getLocStart(),
-                              cond->getLocEnd());
+  SourceRange FirstParenRange(Condition->getLocStart(),
+                              Condition->getLocEnd());
 
   PartialDiagnostic SecondNote =
       Self.PDiag(diag::note_precedence_conditional_first);
 
   SourceRange SecondParenRange(CondRHS->getLocStart(),
-                               rhs->getLocEnd());
+                               RHS->getLocEnd());
 
   SuggestParentheses(Self, OpLoc, Warn, FirstNote, FirstParenRange,
                      SecondNote, SecondParenRange);





More information about the cfe-commits mailing list