[cfe-commits] r132672 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOverload.cpp test/SemaTemplate/dependent-names.cpp test/SemaTemplate/instantiate-call.cpp www/compatibility.html

[Richard Smith]

On Mon, June 13, 2011 15:27, Jay Foad wrote:
>> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Sun Jun  5
>> 17:42:48 2011
>> @@ -2173,6 +2173,10 @@
>>  def err_undeclared_var_use : Error<"use of undeclared identifier %0">;
>>  def note_dependent_var_use : Note<"must qualify identifier to find this
>> "
>>     "declaration in dependent base class">;
>> +def err_not_found_by_two_phase_lookup : Error<"call to function %0 that
>> is neither " +    "visible in the template definition nor found by
>> argument dependent lookup">;
>
> "argument-dependent" should be hyphenated here. :-)

Well, now that you mention it... :)

The C++ standard is inconsistent on the hyphenation (the hyphenated form
has more appearances) but the unhyphenated form is the form with a
definition (see [basic.lookup.argdep]p3). And g++ (trying, but failing, to
be helpful) has a diagnostic 'argument dependent lookup finds ClassName'.

I think the message is clear either way: I'd be happy with any colour for
this bikeshed. But I propose no change. ;)

Richard