[cfe-commits] New files for libcxxabi
Marshall Clow
mclow.lists at gmail.com
Thu Jun 9 13:13:37 PDT 2011
On Jun 8, 2011, at 1:47 PM, John McCall wrote:
>
> On Jun 7, 2011, at 1:15 PM, Marshall Clow wrote:
>
>> Implements the new [] and delete [] functionality.
>> With tests.
>>
>> Comments please.
>> I'm not 100% sure that the exception handling is correct - so that's a good place to look ;-)
>
> The exception handling is not correct: you should be using cleanups instead of try/catch. The best way to do this is with an RAII object which is explicitly disabled on the non-exception path.
Here are modified files (with more tests, too!)
Comments?
-- Marshall
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cxa_vector.cpp
Type: application/octet-stream
Size: 14499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110609/e364811c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_vector1.cpp
Type: application/octet-stream
Size: 8779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110609/e364811c/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_vector2.cpp
Type: application/octet-stream
Size: 4413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110609/e364811c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_vector3.cpp
Type: application/octet-stream
Size: 746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110609/e364811c/attachment-0003.obj>
More information about the cfe-commits
mailing list