[cfe-commits] r132783 - in /cfe/trunk: include/clang/Basic/arm_neon.td test/Sema/arm-neon-types.c

[Bob Wilson]

Author: bwilson
Date: Thu Jun  9 12:03:27 2011
New Revision: 132783

URL: http://llvm.org/viewvc/llvm-project?rev=132783&view=rev
Log:
Add isVCVT_N flag to identify Neon VCVT_N intrinsics, which require special
range checking for immediate operands.  Radar 9558930.

Modified:
    cfe/trunk/include/clang/Basic/arm_neon.td
    cfe/trunk/test/Sema/arm-neon-types.c

Modified: cfe/trunk/include/clang/Basic/arm_neon.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/arm_neon.td?rev=132783&r1=132782&r2=132783&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/arm_neon.td (original)
+++ cfe/trunk/include/clang/Basic/arm_neon.td Thu Jun  9 12:03:27 2011
@@ -75,6 +75,7 @@
   string Types = t;
   Op Operand = o;
   bit isShift = 0;
+  bit isVCVT_N = 0;
 }
 
 // Used to generate Builtins.def:
@@ -297,11 +298,13 @@
 def VCVT_S32     : SInst<"vcvt_s32", "xd",  "fQf">;
 def VCVT_U32     : SInst<"vcvt_u32", "ud",  "fQf">;
 def VCVT_F16     : SInst<"vcvt_f16", "hk",  "f">;
-def VCVT_N_S32   : SInst<"vcvt_n_s32", "xdi", "fQf">;
-def VCVT_N_U32   : SInst<"vcvt_n_u32", "udi", "fQf">;
 def VCVT_F32     : SInst<"vcvt_f32", "fd",  "iUiQiQUi">;
 def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "fd",  "h">;
+let isVCVT_N = 1 in {
+def VCVT_N_S32   : SInst<"vcvt_n_s32", "xdi", "fQf">;
+def VCVT_N_U32   : SInst<"vcvt_n_u32", "udi", "fQf">;
 def VCVT_N_F32   : SInst<"vcvt_n_f32", "fdi", "iUiQiQUi">;
+}
 def VMOVN        : IInst<"vmovn", "hk",  "silUsUiUl">;
 def VMOVL        : SInst<"vmovl", "wd",  "csiUcUsUi">;
 def VQMOVN       : SInst<"vqmovn", "hk",  "silUsUiUl">;

Modified: cfe/trunk/test/Sema/arm-neon-types.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/arm-neon-types.c?rev=132783&r1=132782&r2=132783&view=diff
==============================================================================
--- cfe/trunk/test/Sema/arm-neon-types.c (original)
+++ cfe/trunk/test/Sema/arm-neon-types.c Thu Jun  9 12:03:27 2011
@@ -9,5 +9,12 @@
 
 // ...but should warn when the types really do not match.
 float32x2_t test2(uint32x2_t x) {
-  return vcvt_n_f32_s32(x, 0); // expected-warning {{incompatible vector types}}
+  return vcvt_n_f32_s32(x, 9); // expected-warning {{incompatible vector types}}
+}
+
+// Check immediate range for vcvt_n intrinsics is 1 to 32.  Radar 9558930.
+float32x2_t test3(uint32x2_t x) {
+  // FIXME: The "incompatible result type" error is due to pr10112 and should be
+  // removed when that is fixed.
+  return vcvt_n_f32_u32(x, 0); // expected-error {{argument should be a value from 1 to 32}} expected-error {{incompatible result type}}
 }