[cfe-commits] [PATCH] Even More Abbreviations for PCH Serialization

Jonathan Turner jonathan_d_turner at apple.com
Fri Jun 3 15:44:28 PDT 2011


On Jun 3, 2011, at 3:36 PM, Douglas Gregor wrote:

> 
> On Jun 3, 2011, at 3:33 PM, Jonathan Turner wrote:
> 
>> 
>> On Jun 3, 2011, at 3:16 PM, Douglas Gregor wrote:   
>>> 
>>> Sure, but as long as it always puts *something* into the record, we should be fine.
>> 
>> Good point.  As long as we can assume that TypedefDecl will always have some TypeSourceInfo, we're fine.  I've added an assertion to note this.  If that's sounds good, I'll check in.
> 
> Why is TypedefDecl special in this regard? My assumption is that, if the TypeSourceInfo* is NULL, we'll just end up writing out one element in the VBR array that says "it's a NULL pointer". Is that not true?

Ah, now I see your point.  Yes, you're right, it doesn't matter.  They're fixed now.

Jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110603/dacd42f9/attachment.html>


More information about the cfe-commits mailing list