[cfe-commits] r132564 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td test/SemaCXX/default-arg-special-member.cpp

[Sean Hunt]

Author: coppro
Date: Fri Jun  3 12:55:52 2011
New Revision: 132564

URL: http://llvm.org/viewvc/llvm-project?rev=132564&view=rev
Log:
Implement a warning flag for the warning about default arguments making
special member functions.

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticGroups.td
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
    cfe/trunk/test/SemaCXX/default-arg-special-member.cpp

Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=132564&r1=132563&r2=132564&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Fri Jun  3 12:55:52 2011
@@ -33,6 +33,7 @@
 def Comment : DiagGroup<"comment">;
 def : DiagGroup<"ctor-dtor-privacy">;
 def : DiagGroup<"declaration-after-statement">;
+def DefaultArgSpecialMember : DiagGroup<"default-arg-special-member">;
 def GNUDesignator : DiagGroup<"gnu-designator">;
 
 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">;

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=132564&r1=132563&r2=132564&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Fri Jun  3 12:55:52 2011
@@ -1416,11 +1416,12 @@
   "the %select{reference|const}2 member %3">;
 def warn_default_arg_makes_ctor_special : Warning<
   "addition of default argument on redeclaration makes this constructor a "
-  "%select{default|copy|move}0 constructor">;
+  "%select{default|copy|move}0 constructor">, InGroup<DefaultArgSpecialMember>;
 def note_previous_declaration_special : Note<
   // The ERRORs are in hopes that if they occur, they'll get reported.
   "previous declaration was %select{*ERROR*|a copy constructor|a move "
-  "constructor|*ERROR*|*ERROR*|*ERROR*|not a special member function}0">;
+  "constructor|*ERROR*|*ERROR*|*ERROR*|not a special member function}0">,
+  InGroup<DefaultArgSpecialMember>;
 
 def err_use_of_default_argument_to_function_declared_later : Error<
   "use of default argument to function %0 that is declared later in class %1">;

Modified: cfe/trunk/test/SemaCXX/default-arg-special-member.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/default-arg-special-member.cpp?rev=132564&r1=132563&r2=132564&view=diff
==============================================================================
--- cfe/trunk/test/SemaCXX/default-arg-special-member.cpp (original)
+++ cfe/trunk/test/SemaCXX/default-arg-special-member.cpp Fri Jun  3 12:55:52 2011
@@ -1,4 +1,5 @@
 // RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUM: %clang_cc1 -Wno-default-arg-special-member -Werror -fsyntax-only %s
 
 class foo {
   foo(foo&, int); // expected-note {{was not a special member function}}