[cfe-commits] r132497 - /cfe/trunk/lib/Driver/ToolChains.cpp

[Chandler Carruth]

On Thu, Jun 2, 2011 at 3:18 PM, Rafael Espindola <rafael.espindola at gmail.com
> wrote:

> +  // FIXME: Using CXX_INCLUDE_ROOT is here is a bit of a hack, but
> +  // avoids adding yet another option to configure/cmake.
> +  // It would probably be cleaner to break it in two variables
> +  // CXX_GCC_ROOT with just /foo/bar
> +  // CXX_GCC_VER with 4.5.2
> +  // Then we would have
> +  // CXX_INCLUDE_ROOT = CXX_GCC_ROOT/include/c++/CXX_GCC_VER
>

While I agree deriving the GCC root from the include root is a hack, keep in
mind that we actually use Clang in an environment where the include root is
completely synthetic and doesn't correspond to any GCC root or similar
structure. It really is just an arbitrary root for the C++ standard headers.
I'd like to preserve that functionality with what ever final solution we end
up with.

Having variables dedicated to easily configuring Clang to use existing GCC
installations and versions certainly doesn't seem like a bad thing to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110602/818e8011/attachment.html>