[cfe-commits] [libcxxabi] r132524 - in /libcxxabi/trunk: include/cxxabi.h src/cxa_aux_runtime.cpp src/cxa_virtual.cpp

Howard Hinnant hhinnant at apple.com
Thu Jun 2 19:19:29 PDT 2011


On Jun 2, 2011, at 10:16 PM, Douglas Gregor wrote:

> Marshall, did someone pre-approve this commit?

I did.

> 
> LIBCXXABI_NORETURN should be trivial to implement correctly, given that we have an attribute for it. Why commit a placeholder when it's easier to do the right thing?

We agreed that the placeholder could easily be filled in later.

> 
> Also, any commit needs accompanying tests.
> 
> 
> Please revert this.

Howard




More information about the cfe-commits mailing list