[cfe-commits] [cfe-dev] How to propose patches ?

[Argyrios Kyrtzidis]

On May 21, 2011, at 5:31 AM, Matthieu Monrocq wrote:

> Your new diagnostic for non-virtual destructor looks great and useful, I'd suggest we put it in "most" diagnostic group.
> 
> Thanks for your work!
> 
> -Argyrios
> 
> 
> Here is the new patch with the warning wired up in "most".
> 
> I hope that the final attribute for classes will be implemented soon since it'll remove some false positives for this warning.

It's already implemented, you can check it with cxxRecordDecl->hasAttr<FinalAttr>().

-Argyrios

> 
> Thanks for looking into this!
> 
> -- Matthieu
> 
>  
> 
> <clang_non_virtual_destructor.diff>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110524/81e62a12/attachment.html>