[cfe-commits] r131933 - in /cfe/trunk/lib: AST/Decl.cpp Parse/Parser.cpp Sema/SemaDeclCXX.cpp Sema/SemaTemplateInstantiateDecl.cpp

[Chandler Carruth]

On Mon, May 23, 2011 at 4:14 PM, Sean Hunt <scshunt at csclub.uwaterloo.ca>wrote:

> Implement explicit specialization of explicitly-defaulted constructors.
> The general out-of-line case (including explicit instantiation mostly
> works except that the definition is being lost somewhere between the AST
> and CodeGen, so the definition is never emitted.
>
> Modified:
>    cfe/trunk/lib/AST/Decl.cpp
>    cfe/trunk/lib/Parse/Parser.cpp
>    cfe/trunk/lib/Sema/SemaDeclCXX.cpp
>    cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp
>

Test cases please?

It sounds like you uncovered pre-existing bugs that prevented complete
testing (and/or implementation?). In general it would be much easier to
review if pre-existing bugs were fixed first, and feature additions were
then committed with fairly complete testing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110523/3e57e02e/attachment.html>