[cfe-commits] [cfe-dev] How to propose patches ?

Matthieu Monrocq matthieu.monrocq at gmail.com
Sat May 21 05:31:25 PDT 2011


>
> Your new diagnostic for non-virtual destructor looks great and useful, I'd
> suggest we put it in "most" diagnostic group.
>
> Thanks for your work!
>
> -Argyrios
>
>
Here is the new patch with the warning wired up in "most".

I hope that the final attribute for classes will be implemented soon since
it'll remove some false positives for this warning.

Thanks for looking into this!

-- Matthieu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110521/9f079c2e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang_non_virtual_destructor.diff
Type: application/octet-stream
Size: 5940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110521/9f079c2e/attachment.obj>


More information about the cfe-commits mailing list