[cfe-commits] [patch] please review: is_standard_layout

[Howard Hinnant]

On May 12, 2011, at 3:44 PM, Douglas Gregor wrote:

> 
> On May 12, 2011, at 12:41 PM, Howard Hinnant wrote:
> 
>> I'm trying to enable __has_feature(is_standard_layout).  But I really have no idea what I'm doing in here.  Just copying what is already there.
>> 
>> I've briefly tested __is_standard_layout(T), and note that it has 17 tests in type-traits.cpp.
>> 
>> Thanks,
>> Howard
>> 
>> 
>> Index: lib/Lex/PPMacroExpansion.cpp
>> ===================================================================
>> --- lib/Lex/PPMacroExpansion.cpp	(revision 131239)
>> +++ lib/Lex/PPMacroExpansion.cpp	(working copy)
>> @@ -593,6 +593,7 @@
>>           .Case("is_empty", LangOpts.CPlusPlus)
>>           .Case("is_enum", LangOpts.CPlusPlus)
>>           .Case("is_literal", LangOpts.CPlusPlus)
>> +           .Case("is_standard_layout", LangOpts.CPlusPlus)
>>           .Case("is_pod", LangOpts.CPlusPlus)
>>           .Case("is_polymorphic", LangOpts.CPlusPlus)
>>           .Case("is_trivial", LangOpts.CPlusPlus)
> 
> 
> Looks good. Do you have commit access to Clang SVN?
> 
> 	- Doug

Looks like not:

svn: Commit failed (details follow):
svn: Server sent unexpected return value (400 Bad Request) in response to MKACTIVITY request for '/svn/llvm-project/!svn/act/f031e97d-2e85-4a4e-b404-961803bf70b4'

Howard