[cfe-commits] [patch] Let clang-check actually use the Directory entry in the json file

[Manuel Klimek]

On Mon, May 9, 2011 at 11:40 PM, Nico Weber <thakis at chromium.org> wrote:
> Hi,
> it looks like clang-check currently ignores the 'Directory' key in the json
> file. The attached patch fixes this. Without this, commands with relative -I
> flags do not work for me. Is this ok?

An interesting question might be what happens if the command line
already has a -working-directory flag specified... (I wasn't even
aware that flag exists). I'm fine with doing that later, perhaps add a
FIXME?

> Also, the source says "the json subset as written by cmake" in a few places.
> Can this subset of json be defined somewhere?

Yes, it can and should :) I didn't get around to doing it yet...

Cheers,
/Manuel