[cfe-commits] Patch: Initial improvements to PthreadLockChecker

Rui Paulo rpaulo at apple.com
Mon May 9 17:48:30 PDT 2011


On May 9, 2011, at 5:39 PM, Argyrios Kyrtzidis wrote:

> On May 9, 2011, at 4:49 PM, Ted Kremenek wrote:
> 
>> 
>> On May 9, 2011, at 4:38 PM, Rui Paulo wrote:
>> 
>>> 
>>> Oh, right. The role of lockHistory is to track all the locks that we haven't yet unlocked. The current "state" also does this, but I don't think it keeps an order. I'll have to investigate further. It would be great if I didn't need to add anything to GRState.
> 
> Can you be more specific ? Is it the inconvenient interface ? There's room for improvement for easier use of GRState I think.

As Ted pointed out, I can probably use an ImmutableSet. I will need to explore this route when I have a chance, but I don't think we need improvements to GRState for this.

--
Rui Paulo






More information about the cfe-commits mailing list