[cfe-commits] r130836 - in /cfe/trunk: include/clang/AST/DeclCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td include/clang/Sema/Sema.h lib/Frontend/CompilerInvocation.cpp lib/Sema/Sema.cpp lib/Sema/SemaDeclCXX.cpp test/PCH/cxx0x-delegating-ctors.cpp test/PCH/cxx0x-delegating-ctors.h test/SemaCXX/cxx0x-delegating-ctors.cpp

[Sebastian Redl]

On 04.05.2011, at 08:31, John McCall wrote:

> On May 3, 2011, at 10:57 PM, Sean Hunt wrote:
>> The PCH test is XFAILed because we currently can't deal with a note
>> emitted in the header
> 
> An expected-note on the corresponding line in the main file works.
> It's a hack, but it's one we've used elsewhere.

I've switched to doing PCH tests this way:

// test.cpp
// Without PCH:
// RUN: ... -include test.cpp -fsytax-only test.cpp
// With PCH:
// RUN: ... -emit-pch -o test.pch test.cpp
// RUN: ... -include-pch test.pch -fsyntax-only test.cpp
#if !defined(PASS1)
#define PASS1
// We're the "header"
code here // expected-diagnostic

#else
// Main pass.

#endif

This allows you to place the verify comments where they belong.

Sebastian