[cfe-commits] [PATCH] Fix AST serialization of ReferenceTypes

Douglas Gregor dgregor at apple.com
Mon Apr 11 19:17:51 PDT 2011


On Apr 11, 2011, at 4:40 PM, Richard Smith wrote:

> Hi,
> 
> AST serialization of reference types currently writes out the pointer
> type, not the pointer type as written. This causes a crash when
> deserializing the AST for this:
> 
>  typedef char (&R);
>  extern R &r;
> 
> (I think this is because we save a type reference to a non-top-level
> type). The attached patch fixes this. I also noticed that SpelledAsLValue
> didn't appear to be saved for LValueReferenceTypes, so the patch fixes
> that too.
> 
> OK to check in?

LGTM, thanks!

	- Doug



More information about the cfe-commits mailing list