[cfe-commits] r128760 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp lib/StaticAnalyzer/Core/CoreEngine.cpp

Ted Kremenek kremenek at apple.com
Fri Apr 1 19:56:17 PDT 2011


Author: kremenek
Date: Fri Apr  1 21:56:17 2011
New Revision: 128760

URL: http://llvm.org/viewvc/llvm-project?rev=128760&view=rev
Log:
static analyzer: Rename 'BlocksAborted' to 'BlocksExhausted' to reflect that a given CFGBlock was analyzed too many times.

Modified:
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h
    cfe/trunk/lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp
    cfe/trunk/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp
    cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp

Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h?rev=128760&r1=128759&r2=128760&view=diff
==============================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h (original)
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h Fri Apr  1 21:56:17 2011
@@ -47,7 +47,7 @@
 
 public:
   typedef std::vector<std::pair<BlockEdge, const ExplodedNode*> >
-            BlocksAborted;
+            BlocksExhausted;
 private:
 
   SubEngine& SubEng;
@@ -67,7 +67,7 @@
 
   /// The locations where we stopped doing work because we visited a location
   ///  too many times.
-  BlocksAborted blocksAborted;
+  BlocksExhausted blocksExhausted;
 
   void generateNode(const ProgramPoint& Loc, const GRState* State,
                     ExplodedNode* Pred);
@@ -122,16 +122,16 @@
                                        ExplodedNodeSet &Dst);
 
   // Functions for external checking of whether we have unfinished work
-  bool wasBlockAborted() const { return !blocksAborted.empty(); }
+  bool wasBlockAborted() const { return !blocksExhausted.empty(); }
   bool hasWorkRemaining() const { return wasBlockAborted() || WList->hasWork(); }
 
   WorkList *getWorkList() const { return WList; }
 
-  BlocksAborted::const_iterator blocks_aborted_begin() const {
-    return blocksAborted.begin();
+  BlocksExhausted::const_iterator blocks_aborted_begin() const {
+    return blocksExhausted.begin();
   }
-  BlocksAborted::const_iterator blocks_aborted_end() const {
-    return blocksAborted.end();
+  BlocksExhausted::const_iterator blocks_aborted_end() const {
+    return blocksExhausted.end();
   }
 };
 

Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp?rev=128760&r1=128759&r2=128760&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp Fri Apr  1 21:56:17 2011
@@ -97,7 +97,7 @@
       D->getLocation());
 
   // Emit warning for each block we bailed out on
-  typedef CoreEngine::BlocksAborted::const_iterator AbortedIterator;
+  typedef CoreEngine::BlocksExhausted::const_iterator AbortedIterator;
   const CoreEngine &CE = Eng.getCoreEngine();
   for (AbortedIterator I = CE.blocks_aborted_begin(),
       E = CE.blocks_aborted_end(); I != E; ++I) {

Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp?rev=128760&r1=128759&r2=128760&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp Fri Apr  1 21:56:17 2011
@@ -534,7 +534,7 @@
   CFGReverseBlockReachabilityAnalysis *CRA = AC->getCFGReachablityAnalysis();
   
   // Test for reachability from any aborted blocks to this block
-  typedef CoreEngine::BlocksAborted::const_iterator AbortedIterator;
+  typedef CoreEngine::BlocksExhausted::const_iterator AbortedIterator;
   for (AbortedIterator I = CE.blocks_aborted_begin(),
       E = CE.blocks_aborted_end(); I != E; ++I) {
     const BlockEdge &BE =  I->first;

Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp?rev=128760&r1=128759&r2=128760&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp Fri Apr  1 21:56:17 2011
@@ -310,7 +310,7 @@
   for (llvm::SmallVectorImpl<ExplodedNode*>::const_iterator
        I = nodeBuilder.sinks().begin(), E = nodeBuilder.sinks().end();
        I != E; ++I) {
-    blocksAborted.push_back(std::make_pair(L, *I));
+    blocksExhausted.push_back(std::make_pair(L, *I));
   }
 }
 





More information about the cfe-commits mailing list