[cfe-commits] r128371 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/DiagnosticOptions.h include/clang/Frontend/TextDiagnosticPrinter.h lib/Driver/Tools.cpp lib/Frontend/CompilerInvocati

[Chandler Carruth]

On Sun, Mar 27, 2011 at 10:37 AM, Chris Lattner <clattner at apple.com> wrote:

>
> On Mar 26, 2011, at 6:50 PM, Chandler Carruth wrote:
>
> > Author: chandlerc
> > Date: Sat Mar 26 20:50:55 2011
> > New Revision: 128371
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=128371&view=rev
> > Log:
> > Add an option to suppress include stack printing on note diagnostics.
> > These stacks are often less important than those on primary diagnostics.
> >
> > As the number of notes grows, this becomes increasingly important. The
> > include stack printing is clever and doesn't print stacks for adjacent
> > diagnostics from the same file, but when a note is in between a sequence
> > of errors in a header file, and the notes all refer to some other file,
> > we end up getting a worst-case ping-pong of include stacks that take up
> > a great deal of vertical space.
> >
> > Still, for now, the default behavior isn't changed. We can evaluate user
> > feedback with the flag.
> >
> > Patch by Richard Trieu, a couple of style tweaks from me.
>
> When is printing the include stack for a note ever a good idea?  I think we
> should just remove it unconditionally.
>

That'll teach me to assume that these things were intentional... ;] I'll
flip the default, and if no one complains, remove it. Sound good?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110327/0db3fe4f/attachment.html>