[cfe-commits] r127564 - /cfe/trunk/tools/libclang/CMakeLists.txt

[Douglas Gregor]

On Mar 12, 2011, at 9:59 PM, Óscar Fuentes wrote:

> Francois Pichet <pichet2000 at gmail.com> writes:
> 
>> You can reapply this patch but you need to remove all that: (in Index.h)
>>  #ifdef _CINDEX_LIB_
>>    #define CINDEX_LINKAGE __declspec(dllexport)
>>  #else
>>    #define CINDEX_LINKAGE __declspec(dllimport)
>>  #endif
>> 
>> just do
>>  #define CINDEX_LINKAGE
>> 
>> You can't do dllexport and dllimport stuff for shared libs.
> 
> I think you mean "You can't do dllexport and dllimport stuff for
> *static* libs".
> 
>> I was just about this checkin that but you reverted the patch:(
> 
> I was not aware that libclang was being created as a dll on Windows, so
> when my change forced it to be static, the problem you noticed came to
> being. My intention is to reapply the patch but with the necessary
> modifications for keep building libclang as a dll. Unless someone says
> that static is preferable.

libclang should be built as a DLL. I don't see any reason for it to be a static library.

	- Doug