[cfe-commits] r126762 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/Sema/shift.c
Ted Kremenek
kremenek at apple.com
Tue Mar 1 10:09:31 PST 2011
Author: kremenek
Date: Tue Mar 1 12:09:31 2011
New Revision: 126762
URL: http://llvm.org/viewvc/llvm-project?rev=126762&view=rev
Log:
Don't wanr about "negative shifts" in code that is unreachable. Fixes PR 5544.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/Sema/shift.c
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=126762&r1=126761&r2=126762&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Tue Mar 1 12:09:31 2011
@@ -6641,7 +6641,9 @@
return;
if (Right.isNegative()) {
- S.Diag(Loc, diag::warn_shift_negative) << rex->getSourceRange();
+ S.DiagRuntimeBehavior(Loc, rex,
+ S.PDiag(diag::warn_shift_negative)
+ << rex->getSourceRange());
return;
}
llvm::APInt LeftBits(Right.getBitWidth(),
Modified: cfe/trunk/test/Sema/shift.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/shift.c?rev=126762&r1=126761&r2=126762&view=diff
==============================================================================
--- cfe/trunk/test/Sema/shift.c (original)
+++ cfe/trunk/test/Sema/shift.c Tue Mar 1 12:09:31 2011
@@ -56,3 +56,7 @@
#define ashift 8
enum { b = (a << ashift) };
+// Don't warn for negative shifts in code that is unreachable.
+void test_pr5544() {
+ (void) (((1) > 63 && (1) < 128 ? (((unsigned long long) 1)<<((1)-64)) : (unsigned long long) 0)); // no-warning
+}
More information about the cfe-commits
mailing list