[cfe-commits] [PATCH] include/clang/Basic/BuiltinsX86.def: __builtin_ia32_crc32*() may be defined as unsigned arg.

[Chris Lattner]

On Feb 28, 2011, at 2:17 AM, NAKAMURA Takumi wrote:

> ---
> include/clang/Basic/BuiltinsX86.def |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> 
> It is issue on mingw-w64. Its header /mingw/intrin.h defines as below;
> 
> #if defined(__GNUC__) && \
>   (defined(__i386__) || defined(__x86_64__))
>  extern unsigned int __builtin_ia32_crc32qi (unsigned int, unsigned char);
>  extern unsigned int __builtin_ia32_crc32hi (unsigned int, unsigned short);
>  extern unsigned int __builtin_ia32_crc32si (unsigned int, unsigned int);
> 
> This issue can be avoided with my patch.
> I am still dubious what I do.
> 
> Guys, could you please give me comments?

That's highly dubious, but the patch looks fine to me, please include a testcase though.

-Chris