[cfe-commits] r126342 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/Analysis/retain-release-basic-store.m test/Analysis/retain-release-gc-only.m test/Analysis/retain-release-regio

[Chris Lattner]

On Feb 23, 2011, at 9:00 PM, Chandler Carruth wrote:

> On Wed, Feb 23, 2011 at 8:57 PM, Chris Lattner <clattner at apple.com> wrote:
> Saying "but 'int' only has 32 bits" seems to do the trick, no?  This is a great example of a case with no promotion involved!
> 
> I'm envisioning users responding to this, "but where the hell did an 'int' type come from?". Basically, it's not at all about promotion, it's about the fact that 10 has a distinct type that the operation takes place within prior to being assigned. Maybe I don't give users enough credit, but it seems nice to remind them that the shift itself has a type, and it's not the one they wrote down.
> 
> I don't feel strongly about this though. I see it as nice to have. If it really bothers you, I'll remove it.

I'd really like to keep the warning terse and to the point.  The essays can stay in the static analyzer ;-)

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110223/e41eb863/attachment.html>