[cfe-commits] [PATCH] Reimplement __pragma support

Douglas Gregor dgregor at apple.com
Mon Feb 21 18:02:05 PST 2011


On Feb 20, 2011, at 6:00 PM, Peter Collingbourne wrote:

> This patch series reimplements __pragma using a TokenLexer and reusing
> the original tokens.  This makes diagnostics look better and also
> fixes a bug where we would accept things like __pragma(o n c e).
> It's still not perfect but IMHO an improvement on what we had before.
> 
> I don't have access to the Microsoft headers so it would be good if
> someone (Francois?) could test for regressions against those headers.
> 
> OK to commit?

I'm not a preprocessor expert, but this LGTM.

	- Doug



More information about the cfe-commits mailing list