[cfe-commits] Patches to use PARSE_ARGUMENTS in add_clang_unittest

[Óscar Fuentes]

Jeffrey Yasskin <jyasskin at google.com> writes:

> Doug suggested this to make calls to add_clang_unittest easier to
> read. The macro comes from
> http://www.itk.org/Wiki/CMakeMacroParseArguments.

I'm ok with the patch except for:

> Index: cmake/modules/CMakeLists.txt
> ===================================================================
> --- cmake/modules/CMakeLists.txt	(revision 126022)
> +++ cmake/modules/CMakeLists.txt	(working copy)
> @@ -24,6 +24,7 @@ install(DIRECTORY .
>    PATTERN FindBison.cmake EXCLUDE
>    PATTERN GetTargetTriple.cmake EXCLUDE
>    PATTERN VersionFromVCS.cmake EXCLUDE
> +  PATTERN ParseArguments.cmake EXCLUDE
>    PATTERN CheckAtomic.cmake EXCLUDE)

We must install that file because now it is possible to build Clang
using an installed LLVM. Also I suggest renaming ParseArguments.cmake to
LLVMParseArguments.cmake for avoiding name clashes.