[cfe-commits] r125616 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/Lexer.cpp test/Lexer/rdar-8914293.c

[Douglas Gregor]

On Feb 16, 2011, at 4:28 AM, Sebastian Redl wrote:

> 
> On 16.02.2011, at 05:29, Eli Friedman wrote:
> 
>> On Tue, Feb 15, 2011 at 3:45 PM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
>>> Author: akirtzidis
>>> Date: Tue Feb 15 17:45:31 2011
>>> New Revision: 125616
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=125616&view=rev
>>> Log:
>>> Warn for missing terminating " or ' instead of error for gcc compatibility. Fixed rdar://8914293.
>>> 
>>> Added:
>>>   cfe/trunk/test/Lexer/rdar-8914293.c
>>> Modified:
>>>   cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>>>   cfe/trunk/lib/Lex/Lexer.cpp
>>> 
>>> Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=125616&r1=125615&r2=125616&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)
>>> +++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Tue Feb 15 17:45:31 2011
>>> @@ -45,8 +45,8 @@
>>> 
>>> def ext_token_used : Extension<"extension used">;
>>> 
>>> -def err_unterminated_string : Error<"missing terminating '\"' character">;
>>> -def err_unterminated_char : Error<"missing terminating ' character">;
>>> +def warn_unterminated_string : Warning<"missing terminating '\"' character">;
>>> +def warn_unterminated_char : Warning<"missing terminating ' character">;
>> 
>> Err, ExtWarn?
> 
> And DefaultError?

No, because GCC only emits a warning.

	- Doug