[cfe-commits] r125573 - /cfe/trunk/lib/Sema/SemaDeclObjC.cpp

[Chris Lattner]

On Feb 15, 2011, at 4:08 PM, jahanian wrote:

>> This isn't new to this patch, but 'depercated' is misspelled.
>> 
>>> +  if (S.Diags.getDiagnosticLevel(DIAG, ImplLoc)== Diagnostic::Ignored)
>>> +    return;
>> 
>> There's no need to check to see if the diagnostic is ignored here, it's more efficient to not do this in this case since the warning check is so simple.
> 
> Problem is not with issuing the warning itself (which will be ignored in default mode). Problem is
> with the note (to say where it was declared as deprecated) which will not be ignored in the default case
> (if I undestood you correctly).

Notes should be automatically silenced if the warning/error they are attached to is silenced.

-Chris