[cfe-commits] r125474 - in /cfe/trunk: include/clang/Basic/LangOptions.h include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Lex/Pragma.cpp lib/Parse/ParsePragma.cpp lib/Parse/ParsePragma.h lib/Parse/Parser.cpp lib/Sema/Sema.cpp lib/Sema/SemaAttr.cpp

[Peter Collingbourne]

On Sun, Feb 13, 2011 at 10:49:01PM -0800, Chris Lattner wrote:
> 
> On Feb 13, 2011, at 5:42 PM, Peter Collingbourne wrote:
> 
> > Author: pcc
> > Date: Sun Feb 13 19:42:35 2011
> > New Revision: 125474
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=125474&view=rev
> > Log:
> > Move support for "#pragma STDC FP_CONTRACT" to Parser; add Sema actions
> 
> Hi Peter,
> 
> What is your intention with this flag?  I think that we should warn that it is ignored if the user tries to fiddle with it.  LLVM IR doesn't have a way to pass this (or rounding mode info) through to the IR.

This change is part of the OpenCL support (broken out & refactored
from ARM's patch) and does not change current functionality (although
I agree we should warn for now).  OpenCL requires that FP_CONTRACT
be turned on by default, and the reason for this change is mainly
to ensure that we keep track of the state of FP_CONTRACT in Sema.
I assumed that ARM would be submitting a later patch that respects
this flag in some way, and I am copying in my contact at ARM.

Thanks,
-- 
Peter