[cfe-commits] r125185 - /cfe/trunk/lib/AST/Stmt.cpp

Nick Lewycky nicholas at mxc.ca
Wed Feb 9 00:42:57 PST 2011


Author: nicholas
Date: Wed Feb  9 02:42:57 2011
New Revision: 125185

URL: http://llvm.org/viewvc/llvm-project?rev=125185&view=rev
Log:
Non-void functions need to return some value.

Modified:
    cfe/trunk/lib/AST/Stmt.cpp

Modified: cfe/trunk/lib/AST/Stmt.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Stmt.cpp?rev=125185&r1=125184&r2=125185&view=diff
==============================================================================
--- cfe/trunk/lib/AST/Stmt.cpp (original)
+++ cfe/trunk/lib/AST/Stmt.cpp Wed Feb  9 02:42:57 2011
@@ -91,15 +91,23 @@
   // These silly little functions have to be static inline to suppress
   // unused warnings, and they have to be defined to suppress other
   // warnings.
-  static inline good is_good(good) {}
+  static inline good is_good(good) { return good(); }
 
   typedef Stmt::child_range children_t();
-  template <class T> good implements_children(children_t T::*) {}
-  static inline bad implements_children(children_t Stmt::*) {}
+  template <class T> good implements_children(children_t T::*) {
+    return good();
+  }
+  static inline bad implements_children(children_t Stmt::*) {
+    return bad();
+  }
 
   typedef SourceRange getSourceRange_t() const;
-  template <class T> good implements_getSourceRange(getSourceRange_t T::*) {}
-  static inline bad implements_getSourceRange(getSourceRange_t Stmt::*) {}
+  template <class T> good implements_getSourceRange(getSourceRange_t T::*) {
+    return good();
+  }
+  static inline bad implements_getSourceRange(getSourceRange_t Stmt::*) {
+    return bad();
+  }
 
 #define ASSERT_IMPLEMENTS_children(type) \
   (void) sizeof(is_good(implements_children(&type::children)))





More information about the cfe-commits mailing list