[cfe-commits] [PATCH] Updated python bindings

[Douglas Gregor]

On Feb 5, 2011, at 10:02 AM, Tobias Grosser wrote:

> On 01/17/2011 06:38 PM, Douglas Gregor wrote:
>> 
>> On Dec 28, 2010, at 10:02 PM, Tobias Grosser wrote:
>> 
>>> Hi,
>>> 
>>> here is a patchset that adds some missing functionality to the clang python bindings. It adds enough features to use it in clang_complete[1]
>>> (vim autocompletion) for libclang based auto completion.
>>> 
>>> I would like to commit those patches, and from now on work directly on the clang svn to improve those bindings. Any reviews are therefore highly appreciated.
>> 
>> These look great to me, and I love that someone's pushing the Python bindings forward; please go ahead and commit!
> 
> Thanks. I finally got around to push those changes. They are committed in r124951 to 124959.

Thanks!

> They still need some further work, e.g. diagnostics for completions, but they already work pretty well in clang_complete for vi.


Diagnostics for completions are a little shaky, due to some code-completion-specific optimizations. They may need to be removed from the API, since they can't be implemented efficiently with those optimizations [*].

	- Doug

[*] In particular, we skip parsing function and method bodies while performing code completion, except for the current function/method, which saves a lot of time. However, it means that you'll get inconsistent diagnostics.