[cfe-commits] r124704 - in /cfe/trunk: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp

[Douglas Gregor]

On Feb 2, 2011, at 5:25 AM, Francois Pichet wrote:

> On Tue, Feb 1, 2011 at 6:59 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> Author: dgregor
>> Date: Tue Feb  1 17:59:42 2011
>> New Revision: 124704
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=124704&view=rev
>> Log:
>> Unique code-completion strings. On Cocoa.h, this costs us about 4% in
>> speed but saves us about 25% of the memory usage for strings.
> 
> 
> This or a previous related checkin now cause a regression on windows:
> Seems like the "unavailable" attribute is not printed now.

Thanks for reporting this. I have some cleanup to do with availability handling that I hope will fix this, since I can't reproduce the failure on Darwin :(

	- Doug

> 
> 
> 1>------ Build started: Project: clang-test, Configuration: Release Win32 ------
> 1>  Running Clang regression tests
> 1>  -- Testing: 2813 tests, 4 threads --
> 1>  FAIL: Clang :: Index/complete-exprs.c (1324 of 2813)
> 1>  ******************** TEST 'Clang :: Index/complete-exprs.c' FAILED
> ********************
> 1>  Script:
> 1>  --
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:9
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC1
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1
> c-index-test -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:9
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC1
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1
> c-index-test -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:9
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC1
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:14
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC3
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1
> c-index-test -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:14
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC3
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:18
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC3
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:22
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC3
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:2
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC2
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:11:16
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC4
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:19:3
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC6
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  c-index-test
> -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:24:4
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC7
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1
> c-index-test -code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:24:4
> -Xclang -code-completion-patterns
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c |
> FileCheck -check-prefix=CHECK-CC7
> C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c
> 1>  --
> 1>  Exit Code: 1
> 1>  Command Output (stdout):
> 1>  --
> 1>  Command 0: "c-index-test"
> "-code-completion-at=C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:7:9"
> "-Xclang" "-code-completion-patterns"
> "C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c"
> 1>  Command 0 Result: 0
> 1>  Command 0 Output:
> 1>
> 1>
> 1>  Command 0 Stderr:
> 1>
> 1>
> 1>  Command 1: "FileCheck" "-check-prefix=CHECK-CC1"
> "C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c"
> 1>  Command 1 Result: 1
> 1>  Command 1 Output:
> 1>
> 1>
> 1>  Command 1 Stderr:
> 1>  C:\dev\llvm\llvm_trunk\tools\clang\test\Index\complete-exprs.c:31:15:
> error: expected string not found in input
> 1>  // CHECK-CC1: FunctionDecl:{ResultType int}{TypedText f}{LeftParen
> (}{Placeholder int}{RightParen )} (12) (unavailable)
> 1>                ^
> 1>  <stdin>:129:1: note: scanning from here
> 1>  macro definition:{TypedText __WCHAR_MAX__} (70)
> 1>  ^
> 1>  <stdin>:141:1: note: possible intended match here
> 1>  FunctionDecl:{ResultType int}{TypedText f}{LeftParen
> (}{Placeholder int}{RightParen )} (12)
> 1>  ^
> 1>
> 1>
> 1>  --
> 1>
> 1>  ********************