[cfe-commits] Building EFI with Clang on Mac OS X
dgregor at apple.com
Mon Jan 31 15:21:38 PST 2011
On Jan 31, 2011, at 2:13 PM, Carl Norum wrote:
> On Jan 31, 2011, at 2:12 PM, Carl Norum wrote:
>> Thanks for going over these patches for me. I've attached two new ones, split up as you suggested. My comments follow:
> ... except I didn't actually attach them. Second attempt!
Mach-O patch looks good once the LLVM patches are committed.
--- lib/Serialization/ASTReader.cpp (revision 124313)
+++ lib/Serialization/ASTReader.cpp (working copy)
@@ -96,6 +96,7 @@
The MSBitfields bit should be "important", not "benign", since having -mms-bitfields when creating a PCH file but not when using that PCH file would be rather catastrophic. Otherwise, looks good!
More information about the cfe-commits