[cfe-commits] [PATCH] Check access and ambiguity of delete operator

Alex Miller millerdevel at gmail.com
Mon Jan 31 15:07:06 PST 2011


>
> Patch looks good. Could you provide a test case that we can integrate into
> Clang's test suite, e.g., that extends test/SemaCXX/new-delete.cpp?
>

Done.


> > If someone could point out how to turn the QualType instance representing
> 'Foo *' into just 'Foo', I'd appreciate it.
>
>
> Isn't PointeeElem the type you want to print?
>
> In any case, if you want to dig out the type that a QualType T points to,
> use something like
>
>        if (const PointerType *PointerT = T->getAs<PointerType>()) {
>                // PointerT->getPointeeType() is the type that T points to
>        }
>

Thanks for pointing out that PointeeElem already held the right type. Fixed.


>
> Could you re-submit the patch with those tweaks? Thanks for working on
> this!
>
>        - Doug


Attached and no problem! :)

Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110131/a3055b9a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: delete_access_check.patch
Type: text/x-patch
Size: 2160 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110131/a3055b9a/attachment.bin>


More information about the cfe-commits mailing list