[cfe-commits] patch: improve diagnostic on "class T::iterator" where T::iterator is a typedef

Douglas Gregor dgregor at apple.com
Mon Jan 24 10:51:00 PST 2011


LGTM!

On Jan 23, 2011, at 2:34 PM, Nick Lewycky wrote:

> This patch fixes PR8755, a bug where we give a worse diagnostic when templates are involved than when they aren't. In the case of "class T<A>::iterator" we look up tag types only then error out when one isn't found. The patch works by extended the error path to do a second lookup and report a more informative error when a non-tag type is found.
> 
> Please review!
> 
> Nick
> 
> <pr8755.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list