[cfe-commits] Small fixes

Douglas Gregor dgregor at apple.com
Mon Jan 24 09:28:19 PST 2011

On Jan 20, 2011, at 9:51 AM, Yuri Gribov wrote:

> Hi all,
> 1) I have noticed that constructors are not pretty-printed correctly
> (current implementation is basically a stub) e.g.
>  void f() {
>    A x(1);
>  }
> will result in
>  void f() {
>    A x();
>  }
> which is of course incorrect. I have attached the patch (which is
> basically a copy of VisitCallExpr) which seems to fix it. Could
> someone review/submit it? I tried running the tests but they fail
> mercilessly both with and without my change (yes, I am on Windows) and
> I do not feel like fixing testscripts today.

Looks great, thanks! Committed as r124123.

> 2) it seems that "Hacking on Clang" is somewhat out-of-date - I have
> attached patch for that as well.

IIRC, the --param=build_config=<whatever> setting is only needed for CMake builds. I suggest mentioning this explicitly, so that people using the autoconf builds don't get confused.

> 3) A general question - I am not an official developer; should I send
> patch suggestions to cfe-dev or to cfe-commits?

You've found the right place: cfe-commits.

	- Doug

More information about the cfe-commits mailing list