[cfe-commits] r124087 - in /cfe/trunk: include/clang/Basic/Attr.td include/clang/Sema/AttributeList.h lib/Parse/ParseDeclCXX.cpp lib/Sema/AttributeList.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclAttr.cpp test/CXX/dcl.dcl/dcl.attr/dcl.attr.overrid
Anders Carlsson
andersca at mac.com
Mon Jan 24 08:30:19 PST 2011
On Jan 24, 2011, at 1:00 AM, John McCall wrote:
> On Jan 23, 2011, at 11:56 PM, Abramo Bagnara wrote:
>> Il 24/01/2011 02:52, Anders Carlsson ha scritto:
>>>
>>> On Jan 23, 2011, at 5:50 PM, Nico Weber wrote:
>>>
>>>> Why? Is the plan to reimplement this in some other way?
>>>
>>>
>>> The attributes have been replaced with keywords specified in http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2010/n3206.htm
>>>
>>> clang already supports the new keywords and allows them as an extension in C++98.
>>
>> Syntactic representation apart aren't that properties better stored
>> using clang attributes (i.e. Attr)?
>>
>> This seems appropriate to me both under a conceptual point of view and
>> both thinking about keyword location preserving issues.
>
> I agree; I'm not sure why we had to make these non-Attrs just because they're not actually spelled as attributes anymore.
>
You're absolutely right. Fixed in 124122.
- Anders
More information about the cfe-commits
mailing list