[cfe-commits] Small fixes

Yuri Gribov tetra2005 at googlemail.com
Thu Jan 20 09:51:30 PST 2011


Hi all,

1) I have noticed that constructors are not pretty-printed correctly
(current implementation is basically a stub) e.g.
  void f() {
    A x(1);
  }
will result in
  void f() {
    A x();
  }
which is of course incorrect. I have attached the patch (which is
basically a copy of VisitCallExpr) which seems to fix it. Could
someone review/submit it? I tried running the tests but they fail
mercilessly both with and without my change (yes, I am on Windows) and
I do not feel like fixing testscripts today.

2) it seems that "Hacking on Clang" is somewhat out-of-date - I have
attached patch for that as well.

3) A general question - I am not an official developer; should I send
patch suggestions to cfe-dev or to cfe-commits?

Best regards,
Yuri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: StmtPrinter.cpp.diff
Type: application/octet-stream
Size: 871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110120/30fbb3ac/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hacking.html.diff
Type: application/octet-stream
Size: 960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110120/30fbb3ac/attachment-0001.obj>


More information about the cfe-commits mailing list