[cfe-commits] [PATCH] Win64 (esp. mingw64) stuff

NAKAMURA Takumi geek4civic at gmail.com
Tue Jan 18 16:52:05 PST 2011


Doug,
committed in r123791, thank you!


Anton,

2011/1/19 Anton Korobeynikov <anton at korobeynikov.info>:
> 1. Comment in WinX86_64ABIInfo::computeInfo(CGFunctionInfo &FI) looks
> confusing (it refers to AMD64 ABI)

It was obviously bogus with my copypasto :(
I had started with amd64cc then.

> 2. Usually in llvm codebase the line breaks inside conditions look like:
> if (a &&
>    b || c)

It was one of few differences among my preference and the coding standards.

Fixed in r123790, thank you to point them out!

...Takumi




More information about the cfe-commits mailing list