[cfe-commits] r123192 - in /cfe/trunk: lib/CodeGen/CodeGenModule.cpp test/CodeGen/blocksignature.c test/CodeGen/const-init.c test/CodeGen/darwin-string-literals.c test/CodeGen/func-in-block.c test/CodeGen/predefined-expr.c test/CodeGen/string-literal-short-wstring.c test/CodeGen/string-literal.c test/CodeGenCXX/predefined-expr.cpp test/CodeGenObjC/predefined-expr.m

[Chris Lattner]

On Jan 11, 2011, at 8:31 PM, Rafael Ávila de Espíndola wrote:

>> Hi Rafael,
>> 
>> Is this safe to add to CreateRuntimeVariable?
> 
> Good question. I am not entirely sure when this function is supposed to
> be used. The attached patch enables it for functions and variables, but
> the testsuite doesn't find anything all that interesting.
> 
> BTW, should we allow unnamed_addr in function declarations?

It seems that unnamed_addr should be allowed on function definitions.  If we allow it on function declarations we should allow it on external globals as well.  Is there a use case for it?  It seems reasonable to allow it on declarations...

-Chris