[cfe-commits] r122956 - in /cfe/trunk: include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp test/CodeGen/bool_test_darwin.c test/CodeGen/va_list_test_svr4.c

[Chris Lattner]

On Jan 6, 2011, at 12:27 AM, Roman Divacky wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=122956&view=rev
> Log:
> PowerPC fixes.
> 
> Fix the width and align of bool type on Darwin to be 32bits
> while keeping it 8 everywhere else.
> 
> Change the definition of va_list to default to SV4 ABI one
> and let darwin subtarget override this.
> 
> Both changes submitted by Nathan Whitehorn and reviewed
> by Rafael Espindola.

Very nice.  One minor thing:

Please remove the _darwin and _svr4 suffixes from these tests, and use --check-prefix=DARWINPPC or something like to make it clear that the test is darwin/ppc specific.

-Chris

> 
> +++ cfe/trunk/test/CodeGen/bool_test_darwin.c Thu Jan  6 02:27:10 2011
> @@ -0,0 +1,5 @@
> +// RUN: %clang_cc1 -triple powerpc-apple-darwin -emit-llvm -o - %s| FileCheck %s
> +
> +int boolsize = sizeof(_Bool);
> +//CHECK: boolsize = global i32 4, align 4
> +
> 
> Added: cfe/trunk/test/CodeGen/va_list_test_svr4.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/va_list_test_svr4.c?rev=122956&view=auto
> ==============================================================================
> --- cfe/trunk/test/CodeGen/va_list_test_svr4.c (added)
> +++ cfe/trunk/test/CodeGen/va_list_test_svr4.c Thu Jan  6 02:27:10 2011
> @@ -0,0 +1,6 @@
> +// RUN: %clang_cc1 -triple powerpc-unknown-freebsd -emit-llvm -o - %s| FileCheck %s
> +
> +#include <stdarg.h>
> +
> +int va_list_size = sizeof(va_list);
> +// CHECK: va_list_size = global i32 12, align 4
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits