[cfe-commits] r122643 - in /cfe/trunk: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGStmt.cpp test/CodeGen/asm-variable.c

[Chris Lattner]

On Jan 1, 2011, at 2:03 PM, Rafael Ávila de Espíndola wrote:

>> This warning should be straight-forward to implement: just add an 'isused' bit on AsmLabelAttr and set it in AddVariableConstraits.
>> 
>> Rafael, could you tackle this if you get a chance?
> 
> I have some other issues I have to look at first, but I reported 8881 to track it.

No problem, it certainly isn't critical.  Thanks Rafael!

-Chris

> 
> > Also, please add a doxygen comment to AddVariableConstraits and s/Constraits/Constraints/.
> 
> Done.
> 
>> One other question, what valid code does this ErrorUnsupported reject?  Should it just be a normal error?
>> 
>> +  if (!Target.isValidGCCRegisterName(Register)) {
>> +    CGM.ErrorUnsupported(Variable, "__asm__");
>> +    return Constraint;
>> +  }
> 
> Done.
> 
>> Thanks!
>> 
>> -Chris
> 
> Cheers,
> Rafael