[cfe-commits] r121960 - in /cfe/trunk: include/clang/Analysis/ include/clang/Checker/PathSensitive/ lib/Analysis/ lib/Checker/ test/Analysis/

[Ted Kremenek]

That I understand; I was explicitly stating that this expression can *only* evaluate to a location.

On Dec 20, 2010, at 3:57 PM, Xu Zhongxing wrote:

> I think the rule is simple now: visiting lvalue expression gets location value.
> 
> On Tuesday, December 21, 2010, Ted Kremenek <kremenek at apple.com> wrote:
>> When I was reworking the code I was trying to build a mental model of what visitors only returned lvalues (when using the new lvalue-to-rvalue casts).  We can preserve this as VisitArraySubscriptExpr for consistency.
>> On Dec 17, 2010, at 9:02 PM, Xu Zhongxing wrote:
>> 
>>   /// VisitArraySubscriptExpr - Transfer function for array accesses.
>> -  void VisitArraySubscriptExpr(const ArraySubscriptExpr* Ex, ExplodedNode* Pred,
>> -                               ExplodedNodeSet& Dst, bool asLValue);
>> +  void VisitLvalArraySubscriptExpr(const ArraySubscriptExpr* Ex,
>> +                                   ExplodedNode* Pred,
>> +                                   ExplodedNodeSet& Dst);
>> 
>> Hi Ted,Why not call it VisitArraySubscriptExpr?
>> 
>>