[cfe-commits] r120650 - in /cfe/trunk: include/clang/Basic/Attr.td include/clang/Sema/AttributeList.h lib/CodeGen/CodeGenModule.cpp lib/Sema/AttributeList.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/no-common.c

[Eric Christopher]

On Dec 2, 2010, at 7:38 AM, Douglas Gregor wrote:

> I double that the common and nocommon attributes can go on any declaration... perhaps you want to check for linkage?

I added one set requiring a variable - gcc doesn't go much further than that for a warning. I can definitely refine it a bit more if we'd like to catch some other bogus cases though. (i.e. has to be global, not external, not thread local, etc).

Thoughts?

-eric